Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip OpenIDE-Module-Build-Version from manifest #23

Closed
hg-stolle opened this issue May 29, 2018 · 4 comments
Closed

Strip OpenIDE-Module-Build-Version from manifest #23

hg-stolle opened this issue May 29, 2018 · 4 comments
Milestone

Comments

@hg-stolle
Copy link

First: Thanks for writing this Maven plugin, it is a great help to make our Java builds more reproducible. 👍

However, there is one last obstacle that prevents the build from being reproducible in our case: the manifest files contain an entry like:
OpenIDE-Module-Build-Version: 201805291337
This is basically a timestamp of the build time (29th May 2018, 13:37). Since this entry changes with every build, I would appreciate it if your plugin could remove such an entry from the manifest.mf. Maybe this could also be achieved by providing a way to configure manifest entries that will be removed by the plugin, as suggested in #17 (Additional strippable manifest headers by configuration).

@Zlika Zlika added this to the 0.7 milestone May 29, 2018
@Zlika Zlika closed this as completed in 543f3be May 29, 2018
@Zlika
Copy link
Owner

Zlika commented May 29, 2018

Hi
Could you please compile and test the HEAD version of the plugin to check if this new version fits your needs?
"OpenIDE-Module-Build-Version" attributes are now removed by default, and you can add other user-configurable attributes to the list of attributes that will be removed (#17).
Regards

@hg-stolle
Copy link
Author

hg-stolle commented May 30, 2018

What a swift reaction and fix of the issue. I have to say I am quite impressed.
I've tested the current HEAD (commit 543f3be) of the plugin, and it does solve the issue with OpenIDE-Module-Build-Version. Our builds are now completely reproducible.

Thank you very much.

@Zlika
Copy link
Owner

Zlika commented May 30, 2018

You're welcome. I will release this new version at the end of the week if there is no regression.

@hg-stolle
Copy link
Author

That's good news, I'm looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants