-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip OpenIDE-Module-Build-Version from manifest #23
Comments
Hi |
What a swift reaction and fix of the issue. I have to say I am quite impressed. Thank you very much. |
You're welcome. I will release this new version at the end of the week if there is no regression. |
That's good news, I'm looking forward to it. |
First: Thanks for writing this Maven plugin, it is a great help to make our Java builds more reproducible. 👍
However, there is one last obstacle that prevents the build from being reproducible in our case: the manifest files contain an entry like:
OpenIDE-Module-Build-Version: 201805291337
This is basically a timestamp of the build time (29th May 2018, 13:37). Since this entry changes with every build, I would appreciate it if your plugin could remove such an entry from the manifest.mf. Maybe this could also be achieved by providing a way to configure manifest entries that will be removed by the plugin, as suggested in #17 (Additional strippable manifest headers by configuration).
The text was updated successfully, but these errors were encountered: