-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use varuint encoding for message prefix #123
Comments
our implementation in a sense uses this approach.. |
I believe so, yes For the message |
As discussed in #90 and this previous bug on geth, the message prefix should be encoded using a variable length integer.
I'm learning as I go, but as far as I understand, this is because ascii decimal encoding presents the issue that
...\n12...
is ambiguous. Is it length1
with value2
, or12
. And that using a varuint encoding fixes this.Stacks.js implementation using this encoding
🔗 zboto Link
The text was updated successfully, but these errors were encountered: