Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show NVM errors on screen #163

Open
ghost opened this issue Nov 3, 2021 · 2 comments
Open

Show NVM errors on screen #163

ghost opened this issue Nov 3, 2021 · 2 comments
Labels
enhancement New feature or request P3-Low Low Priority

Comments

@ghost
Copy link

ghost commented Nov 3, 2021

Currently when an error happens due to NVM corruption we just return an error to the APDU, this is because this code was made before we had UI in rust so this was the simplest (and correct) way to handle these kind of issues.

Now that we do have UI in rust, it would be very friendly if we could somewhat display this issue on the screen, so that the user can see what the problem is and also aid in troubleshooting (ie if the screen shows "NVM corrupt" the user needs to change their device)

Related issue: #97

See

//TODO: otherwise return an error and show that on screen (corrupted NVM??)

//TODO: otherwise return an error and show that on screen (corrupted NVM??)

🔗 zboto Link

@ghost ghost added the enhancement New feature or request label Nov 3, 2021
@jleni jleni added the P3-Low Low Priority label Nov 7, 2021
@jleni
Copy link
Member

jleni commented Nov 7, 2021

related to #167
we could eventually change the "ready" to some error related message if the device is not usable anymore.

@ghost
Copy link
Author

ghost commented Nov 7, 2021

Not sure this is related to #167 that much, as these are 2 different situations:
display entrypoint is while showing the transfer operation, where we show the amount fees etc,
this issue is not a "normal" state, like the entrypoint it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3-Low Low Priority
Projects
None yet
Development

No branches or pull requests

1 participant