Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Watermark errors on screen #164

Open
ghost opened this issue Nov 3, 2021 · 0 comments
Open

Show Watermark errors on screen #164

ghost opened this issue Nov 3, 2021 · 0 comments
Labels
enhancement New feature or request P3-Low Low Priority

Comments

@ghost
Copy link

ghost commented Nov 3, 2021 •
edited by zboto bot
Loading

Currently when something fails with the watermark (say it's too low), just an error is returned to the APDU caller, but no other information is shown on screen.

It could be an UX improvement to show something on the screen to better explain what the error is.

See

ledger-tezos/rust/app/src/handlers/baking.rs

Line 208 in ef44255

//TODO: show endorsement data on screen

🔗 zboto Link
@ghost ghost added the enhancement New feature or request label Nov 3, 2021
@jleni jleni added the P3-Low Low Priority label Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P3-Low Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jleni