Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing checks #619

Closed
Seggan opened this issue Dec 17, 2020 · 1 comment
Closed

Missing checks #619

Seggan opened this issue Dec 17, 2020 · 1 comment

Comments

@Seggan
Copy link

Seggan commented Dec 17, 2020

I have gotten a bug report recently from a user of residence and my addon for the plugin Slimefun (see the report for details). I have traced the problem to a missing check for projectiles other than arrows (my bullets are llama spits). In the same report, another issue was pointed out: my grenades do damage. That I found was a lack of an explosion damage check. I also would recommend adding a BlockExplodeEvent handler to handle explosions caused by World#createExplosion. I might submit a pull request for this.

P.S. This is a repost of an issue I submitted on the original Residence repo.

@Seggan
Copy link
Author

Seggan commented Dec 17, 2020

Ok the missing projectile check seems to have been resolved

@Zrips Zrips closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants