Make connection ports configurable (jupyter-server#135)

* allow ports to be configured

* Bump to 0.12.4

Author: Zsailer

data_studio_jupyter_extensions/_version.py

@@ -1 +1 @@
-__version__ = "0.12.3"  # pragma: no cover
+__version__ = "0.12.4"  # pragma: no cover

data_studio_jupyter_extensions/configurables/provisioner.py

@@ -33,19 +33,27 @@ class NotebookServiceProvisioner(provisioning.KernelProvisionerBase):
     """Kernel Provisioner that talks directly to the Notebook Service."""
 
     ip = Unicode(allow_none=True).tag(config=True)
+
     iopub_port = IntFromEnv(
         name=constants.IOPUBPORT, default_value=60317, allow_none=True
-    )
-    hb_port = IntFromEnv(name=constants.HBPORT, default_value=60320, allow_none=True)
+    ).tag(config=True)
+
+    hb_port = IntFromEnv(
+        name=constants.HBPORT, default_value=60320, allow_none=True
+    ).tag(config=True)
+
     control_port = IntFromEnv(
         name=constants.CONTROLPORT, default_value=60319, allow_none=True
-    )
+    ).tag(config=True)
+
     shell_port = IntFromEnv(
         name=constants.SHELLPORT, default_value=60316, allow_none=True
-    )
+    ).tag(config=True)
+
     stdin_port = IntFromEnv(
         name=constants.STDINPORT, default_value=60318, allow_none=True
-    )
+    ).tag(config=True)
+
     namespace = UnicodeFromEnv(name=constants.DS_NAMESPACE, allow_none=True)
 
     kernelspec_id = UnicodeFromEnv(
@@ -450,8 +458,9 @@ async def _launch_kernel_cluster_to_cluster(
         # The connection info should be predetermined by the kernel itself.
         # Get the Host information from the kernel details endpoint.
         kernel_info = await self.nbservice_client.get_kernel_details(self.process_id)
-        self.log.debug(f"Connection Info: {kernel_info}")
+        self.log.debug(f"Kernel Info: {kernel_info}")
         self.ip = self.ip or kernel_info["host"]
+        self.log.debug(f"Connection Info: {self.connection_info}")
         return self.connection_info
 
     async def launch_kernel(

data_studio_jupyter_extensions/tests/configurables/test_provisioner.py

@@ -47,6 +47,15 @@ async def delayed_monkeypatch():
     return _
 
 
+def test_init():
+    nb = NotebookServiceProvisioner()
+    assert nb.iopub_port == 60317
+    assert nb.hb_port == 60320
+    assert nb.control_port == 60319
+    assert nb.shell_port == 60316
+    assert nb.stdin_port == 60318
+
+
 def test_has_process(monkeypatch):
     # Test that has process returns False when
     # no environment variable is set.

pyproject.toml

@@ -23,7 +23,7 @@ testpaths = [
 ]
 
 [tool.tbump.version]
-current = "0.12.3"
+current = "0.12.4"
 regex = '''
   (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)
   ((?P<channel>a|b|rc|.dev)(?P<release>\d+))?

version

@@ -1 +1 @@
-0.12.3
+0.12.4