You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Doing tests for #1076 I've realized most of the tests that currently exists are very naive and just verify general conditions of the result, like "result is a file" or, worse, that the executed code doesn't fail (doesn't raise an exception) without any assertion on the result.
We should improve this by checking actual values of the result. Most of the time, this is possible comparing frames as numpy arrays. For example, to check a "time mirror" effect, the first frame of the input clip should be the last one in the output one.
The text was updated successfully, but these errors were encountered:
mgaitan
changed the title
Assertions in test are very fragile
Assertions in tests are very fragile
Mar 28, 2020
Doing tests for #1076 I've realized most of the tests that currently exists are very naive and just verify general conditions of the result, like "result is a file" or, worse, that the executed code doesn't fail (doesn't raise an exception) without any assertion on the result.
We should improve this by checking actual values of the result. Most of the time, this is possible comparing frames as numpy arrays. For example, to check a "time mirror" effect, the first frame of the input clip should be the last one in the output one.
The text was updated successfully, but these errors were encountered: