You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I'm not sure if we should treat it as a bug or improvement:
When we try to run horusec on Ubuntu 22.04.2 LTS with Docker version 24.0.2, build cb74dfc, we get error:
level=error msg="{HORUSEC_CLI} Your docker version is below of: " error=19.3
We can run with flag -D to disable docker, but then we do not get the benefit of additional tools for analysis. The issue is with how the docker version is validated, more precise - how we get versions internal/controllers/requirements/docker/docker.go:84 - funciton getVersionAndSubVersion:
When we changed line:: subversion, err = strconv.Atoi(fullVersion[3:5])
to subversion, err := strconv.Atoi(strings.Split(fullVersion[3:5], ".")[0])
It starts to work. But the code looks strange, and we need to fork the repo. So it would be good to have a fix for that issue in the original repo and original tool.
Maybe we can already split the string that represents the version number and read the correct one, like this:
Hello, I'm not sure if we should treat it as a bug or improvement:
When we try to run horusec on Ubuntu 22.04.2 LTS with Docker version 24.0.2, build cb74dfc, we get error:
We can run with flag -D to disable docker, but then we do not get the benefit of additional tools for analysis. The issue is with how the docker version is validated, more precise - how we get versions
internal/controllers/requirements/docker/docker.go:84
- funciton getVersionAndSubVersion:And with Atoi we get error:
When we changed line::
subversion, err = strconv.Atoi(fullVersion[3:5])
to
subversion, err := strconv.Atoi(strings.Split(fullVersion[3:5], ".")[0])
It starts to work. But the code looks strange, and we need to fork the repo. So it would be good to have a fix for that issue in the original repo and original tool.
Maybe we can already split the string that represents the version number and read the correct one, like this:
But I don't know what format we can get in fullVersion. Would it always be x.x.x, or can we have other options too?
The text was updated successfully, but these errors were encountered: