Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Leaks engine rules #7

Closed
wiliansilvazup opened this issue Sep 30, 2020 · 3 comments
Closed

Test Leaks engine rules #7

wiliansilvazup opened this issue Sep 30, 2020 · 3 comments
Labels
good first issue Good for newcomers kind/enhancement This issue is related to a new feature or request

Comments

@wiliansilvazup
Copy link
Contributor

What would you like to be added:

Create tests for Leaks analyse rules
https://github.com/ZupIT/horusec/blob/master/development-kit/pkg/engines/leaks/rules/rules_test.go
@fguisso
Copy link
Contributor

fguisso commented Oct 22, 2020

hey guys, I'll try to get this one, you need each func in this file being validate? https://github.com/ZupIT/horusec/blob/e632fe0c4293cdd722f9c9097fa842247b1688ad/development-kit/pkg/enums/engine/advisories/leaks/regular/regular.go

@nathanmartinszup
Copy link
Contributor

Hi @fguisso !
The idea is to do a unit test for each function, passing a piece of vulnerable code that must be detected by the regex.
It is not necessary that all are tested, feel free to do what you feel comfortable with. Even one is of great help.
Thanks for your interest!

@wiliansilvazup wiliansilvazup added good first issue Good for newcomers kind/enhancement This issue is related to a new feature or request and removed good first issue Good for newcomers Hacktoberfest labels Nov 9, 2020
@wiliansilvazup
Copy link
Contributor Author

Added on PR #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement This issue is related to a new feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fguisso @nathanmartinszup @wiliansilvazup