Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Bug: rit init support flags aren't working as expected #1033

Open
GuillaumeFalourd opened this issue Sep 9, 2021 · 1 comment
Open

Bug: rit init support flags aren't working as expected #1033

GuillaumeFalourd opened this issue Sep 9, 2021 · 1 comment
Assignees
Labels
🍎 Mac This issue or pull request is specific to the Mac operating system 🪲 bug Report a bug encountered while operating Ritchie ✔️ refined ISSUE refined by the Ritchie Team 🐧 Linux This issue or pull request is specific to the Linux operating system usability Related to tool usability 💠 Windows This issue or pull request is specific to the Windows operating system

Comments

@GuillaumeFalourd
Copy link
Contributor

What happened:

It seems that the support flags for the rit init commands aren't working as expected.

When we execute the rit init command manually, the metrics and default-formula-runner files are created or updated.

When we execute the rit init command with flags (_e.g: rit init --sendMetrics="no" --addCommons="yes" --runType="docker"
_), the metrics and default-formula-runner files aren't created or updated.

What you expected to happen:

  • I expected the rit init command to work the same way through manual or flags execution.

How to reproduce it (as minimally and precisely as possible):

Run the rit init command manually to check that the metrics and default-formula-runner files are created or updated.

Run the rit init command with flags (_e.g: rit init --sendMetrics="no" --addCommons="yes" --runType="docker"
_) to check that the metrics and default-formula-runner files aren't created or updated.

Anything else we need to know?:

Environment:

  • Ritchie version (use rit --version): 2.12.0 (LTS)
  • Operating System: MacOS + Linux (probably Windows too)

Note

It could be interesting to check this behaviour through the functional tests workflow as well from now.

@GuillaumeFalourd GuillaumeFalourd added 🪲 bug Report a bug encountered while operating Ritchie 💠 Windows This issue or pull request is specific to the Windows operating system 🐧 Linux This issue or pull request is specific to the Linux operating system 🍎 Mac This issue or pull request is specific to the Mac operating system usability Related to tool usability ✔️ refined ISSUE refined by the Ritchie Team labels Sep 9, 2021
@kaduartur
Copy link
Contributor

kaduartur commented Sep 29, 2021

Hi @GuillaumeFalourd @lucasdittrichzup, I would like to fix this bug!

Could you assign me for this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍎 Mac This issue or pull request is specific to the Mac operating system 🪲 bug Report a bug encountered while operating Ritchie ✔️ refined ISSUE refined by the Ritchie Team 🐧 Linux This issue or pull request is specific to the Linux operating system usability Related to tool usability 💠 Windows This issue or pull request is specific to the Windows operating system
Projects
None yet
Development

No branches or pull requests

2 participants