Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Check http status when request stable version #373

Closed
kaduartur opened this issue Aug 7, 2020 · 0 comments · Fixed by #456
Closed

Check http status when request stable version #373

kaduartur opened this issue Aug 7, 2020 · 0 comments · Fixed by #456
Assignees
Labels
🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review
Milestone

Comments

@kaduartur
Copy link
Contributor

What happened:

  • If the stable version server is down, the stable-version-cache.json going to update with an error message.
    For example:
{
  "stableVersion": "<?xml version=\"1.0\" encoding=\"UTF-8\"?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Key>stable-legacyddf.txt</Key><RequestId>D223B393B6FDC09F</RequestId><HostId>HLq0ZVARrOAWLXtUAEwO2LpM/7A4dAyYDXRNWgMkiB3Ov/QGduX8RWPHs+LhYPwOMODW77OXEZ0=</HostId></Error>",
  "expiresAt": 1596848411
}

What you expected to happen:

  • I expect to keep the old version in case an error occurs

How to reproduce it (as minimally and precisely as possible):

  • You can edit the StableVersionUrl variable inside rit code and Unix timestamp inside stable-version-cache.json to get this error.

Anything else we need to know?:

Environment:

  • Ritchie version (use rit --version): 1.0.0 and 2.0.2
  • Operating System: Mx-linux
  • Network plugin / Tool and version (if this is a network-related / tool bug):
  • Others:
@kaduartur kaduartur added 🪲 bug Report a bug encountered while operating Ritchie priority:medium labels Aug 7, 2020
@kaduartur kaduartur added this to the 2.0.4 milestone Aug 7, 2020
@kaduartur kaduartur assigned kaduartur and unassigned kaduartur Aug 11, 2020
@victor-schumacher victor-schumacher self-assigned this Aug 18, 2020
@brunasilvazup brunasilvazup added the 🚧 WIP Work in Progress label Aug 19, 2020
@brunasilvazup brunasilvazup removed this from the 2.0.4 milestone Aug 19, 2020
@victor-schumacher victor-schumacher linked a pull request Aug 21, 2020 that will close this issue
@brunasilvazup brunasilvazup added this to the 2.0.5 milestone Aug 24, 2020
@kaduartur kaduartur changed the title [BUG] Check http status when request stable version Check http status when request stable version Sep 1, 2020
@brunasilvazup brunasilvazup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants