Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Improve 'rit completion bash' command output #524

Closed
victor-schumacher opened this issue Sep 15, 2020 · 6 comments
Closed

Improve 'rit completion bash' command output #524

victor-schumacher opened this issue Sep 15, 2020 · 6 comments
Labels
good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team stale

Comments

@victor-schumacher
Copy link
Contributor

What would you like to be added:

A useful output, informing the command result.
Todays output:
image

Why is this needed:
To understand whether the command was successful or not

@victor-schumacher victor-schumacher added 🔨 improvement Improvement in features Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 15, 2020
@ng29
Copy link

ng29 commented Oct 14, 2020

Hey @victor-schumacher

More info on this will be appreciated, so that can work on this 👍

@victorschumacherzup
Copy link
Contributor

Hey @victor-schumacher

More info on this will be appreciated, so that can work on this

Hi @ng29
Today the command rit completion bash logs alot of useless things, the result is not clear.
The purpose of this issue is to improve the command output, making it compressible.
It became clearer?

@ng29
Copy link

ng29 commented Oct 14, 2020

Hey @victor-schumacher
More info on this will be appreciated, so that can work on this

Hi @ng29
Today the command rit completion bash logs alot of useless things, the result is not clear.
The purpose of this issue is to improve the command output, making it compressible.
It became clearer?

Ahh @victorschumacherzup got clarity on some things in my mind, but can you please share the directory where this command is located. ??

@GuillaumeFalourd
Copy link
Contributor

GuillaumeFalourd commented Oct 14, 2020

Edit: The response of @victorschumacherzup is more accurate below so I edited my comment.

Moreover, @henriquemoraeszup is working on the Developer Guide in this PR: #604 if you want to check how to test your implementation afterwards.

@victorschumacherzup
Copy link
Contributor

victorschumacherzup commented Oct 14, 2020

Of course @ng29 .

func NewAutocompleteBash(g autocomplete.Generator) *cobra.Command {

Package autocomplete is involved as well

@GuillaumeFalourd GuillaumeFalourd added good first issue Good for newcomers ✔️ refined ISSUE refined by the Ritchie Team and removed Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Nov 23, 2020
@stale
Copy link

stale bot commented Jan 22, 2021

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Ritchie a better product!

@stale stale bot added the stale label Jan 22, 2021
@stale stale bot closed this as completed Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers 🔨 improvement Improvement in features ✔️ refined ISSUE refined by the Ritchie Team stale
Projects
None yet
Development

No branches or pull requests

4 participants