Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Increase test coverage rate #560

Closed
GuillaumeFalourd opened this issue Sep 25, 2020 · 5 comments
Closed

Increase test coverage rate #560

GuillaumeFalourd opened this issue Sep 25, 2020 · 5 comments
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ 🔨 improvement Improvement in features

Comments

@GuillaumeFalourd
Copy link
Contributor

What would you like to be added:

  • I would like the Codecov rate coverage to be higher (currently 78% cf README).

Why is this needed:

  • The higher the test coverage rate, the higher will be the product quality.
@GuillaumeFalourd GuillaumeFalourd added good first issue Good for newcomers 🔨 improvement Improvement in features Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 25, 2020
@adi-mohan
Copy link

For this to be done, you need to have a .codecov.yml in .github/ path configured.

@GuillaumeFalourd
Copy link
Contributor Author

Hi @adi-mohan , thank you for your message.

I don't think it's necessary in that case as we run the Codecov analysis in our Circleci pipeline and get the datas afterwards from https://codecov.io to display them on the repository README file.

Is your suggestion a good practice for Codecov use ?

@adi-mohan
Copy link

No. I am new to these technologies. I was curious and was digging in and I found some repositories which have this yml configured at that path. Otherwise, I think someone with the admin rights may only change the coverage rate as desired.

@GuillaumeFalourd
Copy link
Contributor Author

Good to know, thanks @adi-mohan 👍🏼
We actually plan to remove codecov or update the way we use it so we mat go for another tool in the next weeks.

@henriquemoraeszup
Copy link
Contributor

Closing as the current cov rate is above 85% and since @brunasilvazup is responsible for further increasing their reliability

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ 🔨 improvement Improvement in features
Projects
None yet
Development

No branches or pull requests

3 participants