Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Improve formula creation command #653

Closed
fabianofernandeszup opened this issue Nov 4, 2020 · 4 comments
Closed

Improve formula creation command #653

fabianofernandeszup opened this issue Nov 4, 2020 · 4 comments
Labels
📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features
Milestone

Comments

@fabianofernandeszup
Copy link
Contributor

fabianofernandeszup commented Nov 4, 2020

Add questions to fill in the help.json and decription fields of readme and the inputs of config.json.

$ rit create formula
? Enter the new formula command:  rit github publish release
? Choose the language: shell
? Select a formula workspace: default
? Formula description (default blank): Formula to publish a new release on a github project
@fabianofernandeszup fabianofernandeszup added the 🔨 improvement Improvement in features label Nov 4, 2020
@GuillaumeFalourd
Copy link
Contributor

GuillaumeFalourd commented Nov 4, 2020

I remember the first version of the formula creation was like that.

Won't it be too much to config inputs this way with all the current possibilities ?

We can currently configure between 3 and 21 fields for each input. It seems a lot to me to configure all of them through the command line.

@fabianofernandeszup
Copy link
Contributor Author

The configuration of the input is optional, if he wants to use a text editor for this.

@GuillaumeFalourd
Copy link
Contributor

GuillaumeFalourd commented Nov 4, 2020

The configuration of the input is optional, if he wants to use a text editor for this.

Yes, we did it like this last time as well.
It's good to have the option to configure them through the command line.
My doubts are more related to usability: Will the developer really use this option when creating formulas?

I think we should create a form to get feedbacks about this feature first, as it will add a lot of dependencies each time we'll add new inputs configuration options. And we'll have to think about the new formulas templates structure as well.

@henriquemoraeszup henriquemoraeszup added this to the 2.5.0 milestone Nov 16, 2020
@henriquemoraeszup henriquemoraeszup added the 📚 documentation Improvements or additions to documentation label Nov 16, 2020
@henriquemoraeszup
Copy link
Contributor

Resolved in a more automated manner by #689

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features
Projects
None yet
Development

No branches or pull requests

3 participants