add capabilities to register new font's directories #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. Do you mind if I merge only the font directories commit? This project's style is with tabs, I like them (and it's easier to do occasional edit on a vim-less PC). |
|
No, I don't mind but you should use spaces as required from Python (by PEP8) and specially if someone is using a Python IDE (as Spyder) it start to mix spaces and tabs and this is really a mess. Obviously you are free to use tabs ;-) |
|
PEP is not a requirement (if not contributing to python itself), but merely a recommendation. Modern IDEs are able to see what kind of indentation is needed. |
|
Ok, so merge only the font directories commit. |
|
Closed with d557d4b (sorry, had to copy-paste edits instead of merging). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these two commits I added the capabilities to register new font's directories and cleanup the code replacing tabs with space.