Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer builds Arch #227

Open
jayray-git opened this issue Apr 3, 2024 · 6 comments
Open

No longer builds Arch #227

jayray-git opened this issue Apr 3, 2024 · 6 comments

Comments

@jayray-git
Copy link

ipt-netflow/ipt_NETFLOW.c:4090:17: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’? [-Werror=implicit-function-declaration]
4090 | strlcpy(info.driver, dev->dev.parent->driver->name, sizeof(info.driver));
| ^~~~~~~
| strscpy
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:243: ipt-netflow/ipt_NETFLOW.o] Error 1
make[2]: *** [/usr/lib/modules/6.8.2-arch2-1/build/Makefile:1921: ipt-netflow] Error 2
make[1]: *** [Makefile:240: __sub-make] Error 2
make[1]: Leaving directory '/usr/lib/modules/6.8.2-arch2-1/build'
make: *** [Makefile:27: ipt_NETFLOW.ko] Error 2

@svlobanov
Copy link

strlcpy has been removed from Linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d26270061ae66b915138af7cd73ca6f8b85e6b44

try to replace strlcpy to strscpy

@jayray-git
Copy link
Author

perl -pi -e 's/strlcpy/strscpy/' *
^works

@svlobanov
Copy link

Please re-open the issue. It should be fixed in master branch. Otherwise, somebody else will open the same issue

@jayray-git
Copy link
Author

*reopened

@jayray-git jayray-git reopened this Apr 4, 2024
@juju4
Copy link

juju4 commented Nov 3, 2024

Still seeing strlcopy here and few more
https://github.com/aabc/ipt-netflow/blob/master/ipt_NETFLOW.c#L4090
wrongly fixed by adding back strlcopy in #230

Confirming suggested replacement works directly as per https://github.com/juju4/ansible-ipt-netflow/actions/runs/11655352850/job/32449937461

@jayray-git
Copy link
Author

#235 @juju4 there are mote issues - patch fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants