Fix: PG::SyntaxError: Replace 'DISCARD ALL' query to similer operations. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DISCARD` was implemented on PostgreSQL since v8.3 However, Redshift is based on PostgreSQL 8.0.2 References * [PostgreSQL DISCARD](https://www.postgresql.org/docs/current/static/sql-discard.html) * [Amazon Redshift and PostgreSQL](http://docs.aws.amazon.com/redshift/latest/dg/c_redshift-and-postgres-sql.html)
taise
force-pushed
the
fix/discard_is_not_valid
branch
from
ff4f777 to
92d3ae7
Compare
* Redshift has only 'DEALLOCATE plan_name', and doesn't have 'DEALLOCATE ALL'
> Closes all of the free resources that are associated with an open cursor. > COMMIT, END, and ROLLBACK automatically close the cursor [Amazon Redshift - CLOSE](http://docs.aws.amazon.com/redshift/latest/dg/close.html)
|
+1 |
cschulte22
added a commit
to getletterpress/activerecord5-redshift-adapter
that referenced
this pull request
Jan 22, 2018
ghost
mentioned this pull request
benjyblack
added a commit
to wealthsimple/activerecord5-redshift-adapter
that referenced
this pull request
Mar 11, 2020
Porting this fix over aamine/activerecord4-redshift-adapter#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCARDwas implemented on PostgreSQL since v8.3However, Redshift is based on PostgreSQL 8.0.2
References
Fix: #25