How to exclude "node_modules" in BuckleScript/Jest project?

[jihchi]

Hi and thanks for the great tool!

I'm working on this the draft, trying to switch to bisect ppx from Jest. I am able to generate code coverage report, but the report includes a 3rd-party library:

I'm wondering how to exclude 3rd-party libraries under node_modules folder?

[aantron]

@jihchi node_modules is actually already excluded, because BuckleScript doesn't apply your bsconfig.json to any of the code that's from a third-party module, in particular, it doesn't apply your project's ppx-flags to node_modules/bs-bastet.

What's happening is that bs-bastet itself also uses Bisect_ppx, so it's also getting instrumented when you run with BISECT_ENABLE=yes. rescript-lang/rescript#3761 will add dev-only ppx-flags, which will allow bs-bastet (and relude) to automatically not depend on Bisect at all when they are installed as third-party packages.

I understood from @bobzhang that rescript-lang/rescript#3761 will be included in the next release of BuckleScript (7.4?), so I suggest we wait until then, instead of trying to implement some workaround.

(Note that we need dev-only ppx-flags apart from any workaround we could implement in Bisect, because we want to make sure that released packages never even try to call Bisect, and thus don't depend on it being installed at all).

Also cc @Risto-Stevcev.

[aantron]

Going to close this for now, as it is tracked in BuckleScript.