Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --conditional and update Dune instructions #318

Closed
aantron opened this issue Apr 27, 2020 · 3 comments
Closed

Deprecate --conditional and update Dune instructions #318

aantron opened this issue Apr 27, 2020 · 3 comments
Labels
upstream

Comments

@aantron
Copy link
Owner

aantron commented Apr 27, 2020

It is no longer recommended for Dune. It is only used internally by the BuckleScript wrapper, but that wrapper can just set the reference directly that --conditional would set if passed on the command line.
@aantron
Copy link
Owner Author

aantron commented Apr 27, 2020

--conditional causes problems with the Dune artifact cache with recent versions of Dune, so it is best to start moving away from it.

@aantron aantron changed the title Deprecate --conditional now Deprecate --conditional May 9, 2020
@aantron aantron changed the title Deprecate --conditional Deprecate --conditional and update dune instructions May 9, 2020
@aantron
Copy link
Owner Author

aantron commented May 9, 2020

With ocaml/dune#57 resolved, the next Dune release should include an initial proper Bisect_ppx integration. We should deprecate --conditional then, and add instructions to the README about how to use Bisect_ppx with Dune without having to write dune files in OCaml syntax. See also #323.

@aantron aantron changed the title Deprecate --conditional and update dune instructions Deprecate --conditional and update Dune instructions May 9, 2020
@aantron
Copy link
Owner Author

aantron commented May 10, 2020

Closing in favor of #323.

@aantron aantron closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aantron