Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dream-mirage after deprecated values were removed #277

Closed
aantron opened this issue May 11, 2023 · 2 comments
Closed

Update dream-mirage after deprecated values were removed #277

aantron opened this issue May 11, 2023 · 2 comments

Comments

@aantron
Copy link
Owner

aantron commented May 11, 2023

In CI:

File "duniverse/dream/src/mirage/mirage.ml", line 349, characters 4-16:
349 |     Tag.form_tag ~now ?method_ ?target ?enctype ?csrf_token ~action request
          ^^^^^^^^^^^^
Error: Unbound value Tag.form_tag
Hint: Did you mean csrf_tag?

Deprecated values and internal helpers they depend on, such as Tag.form, were removed in e14bd91. The Mirage .mli should be updated to match.

@tmcgilchrist
Copy link
Contributor

Fixed in #283

@aantron
Copy link
Owner Author

aantron commented Nov 2, 2023

Fixed by #283 as mentioned by @tmcgilchrist.

@aantron aantron closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants