Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to show a webmention without any content? #54

Closed
nhoizey opened this issue Aug 7, 2017 · 3 comments
Closed

How to show a webmention without any content? #54

nhoizey opened this issue Aug 7, 2017 · 3 comments

Comments

@nhoizey
Copy link
Contributor

nhoizey commented Aug 7, 2017

I received a webmention that doesn't show anything with the default template:
https://nicolas-hoizey.com/2017/07/so-long-disqus-hello-webmentions.html#webmention-447800

Here's the data:

  '447800':
    id: '447800'
    url: https://open-time.net/post/2017/07/29/Webmentions-en-coreen
    source: false
    pubdate: 2017-07-29 07:22:51.000000000 +02:00
    raw:
      source: https://open-time.net/post/2017/07/29/Webmentions-en-coreen
      verified: true
      verified_date: '2017-07-29T05:22:51+00:00'
      id: 447800
      private: false
      data:
        url: https://open-time.net/post/2017/07/29/Webmentions-en-coreen
        name: 
        content: 
        published: 
        published_ts: 
      activity:
        type: link
        sentence: https://open-time.net/post/2017/07/29/Webmentions-en-coreen posted
          '' linking to https://nicolas-hoizey.com/2017/07/so-long-disqus-hello-webmentions.html
        sentence_html: <a href="https://open-time.net/post/2017/07/29/Webmentions-en-coreen">someone</a>
          posted '' linking to <a href="https://nicolas-hoizey.com/2017/07/so-long-disqus-hello-webmentions.html">https://nicolas-hoizey.com/2017/07/so-long-disqus-hello-webmentions.html</a>
      target: https://nicolas-hoizey.com/2017/07/so-long-disqus-hello-webmentions.html
    type: link
    content: ''

Maybe it could use the URL if there's no content.

@aarongustafson
Copy link
Owner

I think I would prefer to fall back to the sentence_html. Any reason you wouldn’t want that?

FWIW - you’ll still have access to any part in your templates via the raw hash.

@aarongustafson
Copy link
Owner

Should be working in 2.6.3

@nhoizey
Copy link
Contributor Author

nhoizey commented Aug 9, 2017

sentence_html is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants