"[jekyll-webmention_io] Liquid error: internal" error when using includes in Webmention templates

[nhoizey]

I have created a few templates for specific Webmention types:
https://github.com/nhoizey/nicolas-hoizey.com/tree/master/_includes/webmentions

The code for the author avatar is copy/pasted multiple times, so I wanted to share it in an include.

But when I try to serve or build the site, I get this error:

[jekyll-webmention_io] Liquid error: internal

I have to say that I'm currently using version 2.9.1 of this plugin because of incompatible shared dependencies. I'll try to remove the other plugin to test with latest version.

[nhoizey]

I made a branch with these includes:
https://github.com/nhoizey/nicolas-hoizey.com/tree/shared-webmention-author-photo/_includes/webmentions

[aarongustafson]

Ok weird. I’ll take a look.

Sounds like I need to figure out how to handle includes in includes ;-)

[twhite96]

@nhoizey how did you get the plugin to work with your templates? Whenever I build the template tags in the head of my blog all have display:none as either an id or class. Not sure what I am doing wrong.

[aarongustafson]

I am hitting my head against the wall here. It looks like the Liquid parser needs to know about the other Liquid Tags in the project, which I can get from the site_payload, but I’m not sure how exactly to merge that info and the @DaTa hash in order to get them both resolved into the template. Any help here would be greatly appreciated :-)

[ashmaroli]

@nhoizey Is there any additional info available when you try to build with the above includes via the
--trace option..?

bundle exec jekyll build --trace

[aarongustafson]

@ashmaroli Tracing this gives no additional error information in my experience.

Here’s the code I’m using to do the Liquid parsing & rendering:

template = Liquid::Template.parse(@template, :error_mode => :strict)
html = template.render(@data, { :strict_variables => false, :strict_filters => true })

@template contains the default or custom template markup (where the {% include … %} exists. Do I (maybe) need to pass in a reference to the includes folder path or something?

I can’t seem to find any docs on how to do this properly.

[aarongustafson]

Worth noting, I tried this with additional liquid tags and get the same error. I tried both highlight and link. Liquid internals like conditionals are not a problem. It leads me to believe the Liquid parser doesn’t have access to the Jekyll instance tags.

[aarongustafson]

Yeah, raw works fine.

[ashmaroli]

I tried this with additional liquid tags and get the same error.

Can you provide me with a minimal, reproducible repo that I can use to encounter this error at my end..?
Alternatively, is there any difference in the output if you set Liquid to parse @template with
error_mode => :warn..?

[aarongustafson]

I have a local test site I use. It’s a skeleton demo but should work. I don’t have it in Github because there’s no point, but here’s a ZIP of everything but the vendor directory.

test-site.zip

[ashmaroli]

I've traced the bug behind this.. will send a PR shortly..

[nhoizey]

@twhite96 my build works with my current master branch, but not the one I linked to in the comment before yours.

[aarongustafson]

Resolved in 2.9.7.