Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gas calculations to the response of the tx #76

Merged
merged 9 commits into from
Feb 16, 2021
Merged

feat: add gas calculations to the response of the tx #76

merged 9 commits into from
Feb 16, 2021

Conversation

damarnez
Copy link
Contributor

No description provided.

@damarnez damarnez requested a review from sendra February 16, 2021 09:53
sakulstra
sakulstra suggested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@sakulstra sakulstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks overall good to me, but includes a package-lock although we use yarn
please remove the lockfile

@sakulstra sakulstra changed the title Add gas calculations to the response of the TX. feat: add gas calculations to the response of the tx Feb 16, 2021
@eboadom eboadom merged commit 3ee1934 into master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sendra sendra sendra approved these changes

@sakulstra sakulstra sakulstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damarnez @sakulstra @sendra @eboadom