Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] import { LendingPool } from @aave/contracts #11

Open
pi0neerpat opened this issue May 10, 2020 · 1 comment
Open

[feature request] import { LendingPool } from @aave/contracts #11

pi0neerpat opened this issue May 10, 2020 · 1 comment

Comments

@pi0neerpat
Copy link

We had an excellent submission coming from the Hack Money hackathon (https://github.com/rtoken-project/rtoken-monorepo/pull/64/files), however I noticed lots of un-edited files were copy/pasted from this repo. Rather, I would like to be able to do this:

import { LendingPool } from @aave/contracts

We recently added this to the rToken contracts repo (see https://github.com/rtoken-project/rtoken-monorepo/blob/41cfd3b8be805f1ca19a4d9d49e4aae39e8db6c0/packages/contracts/package.json#L9) and its pretty simple to do. Happy to help guide the conversation here as it would be very useful and is becoming standard practice in the community.

@mrdavey
Copy link

mrdavey commented May 11, 2020

Thanks for the suggestion @pi0neerpat . We'll try to have this available by end of the week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants