Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default initialize #846

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

sakulstra
Copy link
Collaborator

@sakulstra sakulstra commented Apr 28, 2023

It doesn't really make sense to initialize here with 9 and 0, and then in deploy script update it via common config to 5 and 4.
Generally it doesn't make to much sense to initialize potentially changing values in initialize as potentially every upgrade will reset them. Probably better to initialize as 0 and set them as part of the deploy pipeline (in fact that's already done for these two values).

@height
Copy link

height bot commented Apr 28, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@miguelmtzinf
Copy link
Contributor

miguelmtzinf commented Jul 4, 2023

It does not make the difference either way in my opinion: initialize with final fee parameters vs initialize without parameters and call setters.

I am fine with removing this initial config and go with the second approach

@miguelmtzinf miguelmtzinf merged commit 3bb960b into aave:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants