-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove default initialize #846
fix: remove default initialize #846
Conversation
|
It does not make the difference either way in my opinion: initialize with final fee parameters vs initialize without parameters and call setters. I am fine with removing this initial config and go with the second approach |
It doesn't really make sense to initialize here with 9 and 0, and then in deploy script update it via common config to 5 and 4.
Generally it doesn't make to much sense to initialize potentially changing values in initialize as potentially every upgrade will reset them. Probably better to initialize as 0 and set them as part of the deploy pipeline (in fact that's already done for these two values).