Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainnet: ENS Oracle never registered - Price is zero and priceSource is 0x0 #79

Open
vicnaum opened this issue Jul 29, 2022 · 1 comment

Comments

@vicnaum
Copy link

vicnaum commented Jul 29, 2022

Describe the bug
ENS price is always zero, doesn't have price history, and ENS PriceSource was never registered - it's still 0x0.

Details & History:
ENS Token was added to Aave in March 2022 with Proposal 63:
https://staging.aave.com/governance/proposal/63/
And the ENS Oracle was set at block 14338029 at 07 Mar 2022:
https://etherscan.io/tx/0x47c2b4fc4c0226373a0ad1a86249f4668519447bac3504ec1cb928a9c221d35a

The corresponding AssetSourceUpdated event was emitted successfully.

But the Oracle used isn't the standard ChainLink Proxy, but a custom smart contract called EnsUsdToEnsEth that calculates ENS/ETH price from ENS_USD and USD_ETH (using two ChainLink sources):
https://etherscan.io/address/0xd4641b75015E6536E8102D98479568D05D7123Db#code

It has latestAnswer() method, but doesn't has other methods

Supposedly, this bug happens, because ENS Oracle isn't standard ChainLink proxy and doesn't have aggregator, thus doesn't pass the "try_aggregator()" call at:

let aggregatorAddressCall = chainlinkProxyInstance.try_aggregator();

So presumably it fails there and never gets further.

To Reproduce
This query can be used in TheGraph Playground:

{
  priceOracleAsset (id: "0xc18360217d8f7ab5e7c516566761ea12ce7f9d72") {
    id
    priceSource
    priceInEth
  }
}

Expected behavior
Some workaround or exception should be made for handling the ENS oracle - it should be registered as a PriceSource and provide price updates.

@defispartan
Copy link
Contributor

Thanks for the detailed report, we'll look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants