Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class rationals.MixPlay seems to be only partially implemented #8

Open
andrewdbate opened this issue Apr 1, 2015 · 4 comments
Open

Comments

@andrewdbate
Copy link
Collaborator

The class rationals.MixPlay seems to be only partially implemented. In particular, the method checkAccessibleWith() always returns true and other methods call this method.

Looking quickly, it may be that calls to checkAccessibleWith() are an optimization only, in which case they should be removed. Otherwise, the class itself should probably be removed. (It can always be reimplemented based upon the current version at a later date if needs be.)

Do you agree with this assessment? Many thanks!

@abailly
Copy link
Owner

abailly commented Apr 2, 2015

I implemented this class to have a more "efficient" computation of Mix product than the text-book definition, because at the time I needed to do it online, e.g. compute mix product of several automata step by step with live feedback. So yes, I suggest you keep the class and remove the unimplemented method(s).

@andrewdbate
Copy link
Collaborator Author

Could you give a good reference for the Mix product of two automatons? I don't seem to be able to find very much using Google...

@abailly
Copy link
Owner

abailly commented Apr 2, 2015

It's also called Synchronisation product: http://users.abo.fi/jboling/cdes/op_on_aut.pdf

@andrewdbate
Copy link
Collaborator Author

Great, thanks. I thought that that class was just computing the product, but I wanted to be 100% sure that it wasn't also supposed to be doing something else as well. Do you think that the class should be renamed Product, since that name seems to be more standard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants