You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The class rationals.MixPlay seems to be only partially implemented. In particular, the method checkAccessibleWith() always returns true and other methods call this method.
Looking quickly, it may be that calls to checkAccessibleWith() are an optimization only, in which case they should be removed. Otherwise, the class itself should probably be removed. (It can always be reimplemented based upon the current version at a later date if needs be.)
Do you agree with this assessment? Many thanks!
The text was updated successfully, but these errors were encountered:
I implemented this class to have a more "efficient" computation of Mix product than the text-book definition, because at the time I needed to do it online, e.g. compute mix product of several automata step by step with live feedback. So yes, I suggest you keep the class and remove the unimplemented method(s).
Great, thanks. I thought that that class was just computing the product, but I wanted to be 100% sure that it wasn't also supposed to be doing something else as well. Do you think that the class should be renamed Product, since that name seems to be more standard?
The class rationals.MixPlay seems to be only partially implemented. In particular, the method
checkAccessibleWith()
always returnstrue
and other methods call this method.Looking quickly, it may be that calls to
checkAccessibleWith()
are an optimization only, in which case they should be removed. Otherwise, the class itself should probably be removed. (It can always be reimplemented based upon the current version at a later date if needs be.)Do you agree with this assessment? Many thanks!
The text was updated successfully, but these errors were encountered: