New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cloud Run Job Terraform into a common module #307

Open

lock14 opened this issue Jul 29, 2024 · 0 comments

Labels

Contributor

lock14 commented Jul 29, 2024 •

edited

Loading

TL;DR

There is a quite a bit of similarity in the terraform for the two cloud run jobs:
https://github.com/abcxyz/github-metrics-aggregator/tree/main/terraform/modules/artifacts
https://github.com/abcxyz/github-metrics-aggregator/tree/main/terraform/modules/commit_review_status

It might be nice to pull out the commonalities into a terraform module that can be re-used. We've done this previously for our Cloud Run Services:
https://github.com/abcxyz/terraform-modules/tree/main/modules/cloud_run

Detailed design

No response

Alternatives considered

No response

Additional information

No response

lock14 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment