Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write UT for public methods if it is possible #108

Open
capri-xiyue opened this issue Aug 4, 2022 · 0 comments
Open

Write UT for public methods if it is possible #108

capri-xiyue opened this issue Aug 4, 2022 · 0 comments
Labels
cleanup Refactoring, cleanup... good first issue Good for newcomers

Comments

@capri-xiyue
Copy link
Contributor

TL;DR

Write UT for public methods instead of private methods if it is possible

jvs/pkg/jvscrypto/cert_action_api_test.go

Line 306 in 23cdda1

gotErr := service.certificateAction(ctx, tc.request)
and

jvs/pkg/jvscrypto/key_hosting_test.go

Line 124 in 23cdda1

got, err := ks.generateJWKString(ctx)

Detailed design

No response

Alternatives considered

No response

Additional information

No response
@capri-xiyue capri-xiyue added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2022
@yolocs yolocs added cleanup Refactoring, cleanup... and removed enhancement New feature or request labels Aug 31, 2022
@capri-xiyue capri-xiyue added the p2 label Jan 9, 2023
@sailorlqh sailorlqh mentioned this issue Mar 15, 2023
Merged
@yolocs yolocs removed the p2 label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Refactoring, cleanup... good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yolocs @capri-xiyue