Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real services for integration test #158

Open
yolocs opened this issue Nov 28, 2022 · 2 comments
Open

Use real services for integration test #158

yolocs opened this issue Nov 28, 2022 · 2 comments
Assignees
@sqin2019
Labels
cleanup Refactoring, cleanup... test

Comments

@yolocs
Copy link
Contributor

yolocs commented Nov 28, 2022

At the moment, we don't run real services in integration tests. Instead, we launch services in Go tests. This is not ideal since it doesn't provide test coverage on the real container images we release.

Per #157, we had a bug in the dockerfile that caused bad container images. The integration test didn't catch that and we only realized the issue when we were trying to deploy the images.
@yolocs
Copy link
Contributor Author

yolocs commented Nov 28, 2022

cc: @sqin2019

@capri-xiyue capri-xiyue added enhancement New feature or request test p2 cleanup Refactoring, cleanup... and removed enhancement New feature or request labels Jan 9, 2023
@sqin2019 sqin2019 self-assigned this Mar 27, 2023
@sqin2019 sqin2019 mentioned this issue Apr 4, 2023
Closed
@yolocs
Copy link
Contributor Author

yolocs commented Apr 14, 2023

FYI: https://github.com/abcxyz/jvs/blob/main/.github/workflows/integration.yml doesn't really work.

@yolocs yolocs removed the p2 label Jun 7, 2023
@yolocs yolocs mentioned this issue Jul 6, 2023
Merged
@sailorlqh sailorlqh mentioned this issue Aug 31, 2023
Closed
This was referenced Sep 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sqin2019 sqin2019

Labels
cleanup Refactoring, cleanup... test
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yolocs @sqin2019 @capri-xiyue