JVS client cannot be initialized with raw JVS client config directly

[yolocs]

TL;DR

We provide a raw JVS config to initialize a JVS client

https://github.com/abcxyz/lumberjack/blob/main/clients/go/pkg/auditopt/config.go#L262

It will fail because the new config defaulting logic in JVS client requires the use envconfig. Constructing a JVSConfig directly won't set defaults.

Expected behavior

No response

Observed behavior

No response

Environment Details

See above

Additional information

No response

[sethvargo]

@yolocs do you think jvs should provide a NewClient option that initializes things?

[yolocs]

Probably. Although I don't necessarily see it as "lacking option" problem since the raw config is already kind of an option. I see it more as a "lacking a lib to load config with defaults" problem.
See context in abcxyz/jvs#104. Maybe it's a good idea to add that to pkg.

[yolocs]

Send a PR for the idea: abcxyz/pkg#33

[yolocs]

PR in pkg merged. Will create a new issue to adopt the new lib in lumberjack