Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging on Windows command prompt can be garbled #34

Closed
1 of 2 tasks
abelcheung opened this issue Nov 20, 2023 · 2 comments
Closed
1 of 2 tasks

Logging on Windows command prompt can be garbled #34

abelcheung opened this issue Nov 20, 2023 · 2 comments
Labels
bug windows Windows specific issues wontfix
Milestone
0.9 release

Comments

@abelcheung
Copy link
Owner

abelcheung commented Nov 20, 2023 •
edited
Loading

Currently glib logging doesn't use Windows console API, unlike stdout / stderr counterparts. Sometimes it can contain garbled characters (like ideographic quotes).

  • Possibly need a replacement of g_log_default_handler()
  • stdout handle needs to be initiated early too, for help message printing.
@abelcheung abelcheung added bug windows Windows specific issues labels Nov 20, 2023
@abelcheung abelcheung added this to the 0.8 milestone Nov 20, 2023
@abelcheung abelcheung self-assigned this Nov 20, 2023
@abelcheung abelcheung moved this from Consider to Todo in Rifiuti2 progress Nov 20, 2023
@abelcheung abelcheung modified the milestones: 0.8, 0.9 Nov 27, 2023
@abelcheung
Copy link
Owner Author

Delayed milestone for this issue. Replacing g_log_default_handler() requires copying large chunk of glib code that recurses deep down, and seems to require glib internal funcs too. Not an easy replacement, and probably unworthy, as log messages are already in English and unlocalised now. Current problem mainly happens in unicode quotes.

@abelcheung abelcheung moved this from Todo to Consider in Rifiuti2 progress Nov 27, 2023
@abelcheung abelcheung removed their assignment Nov 27, 2023
@abelcheung
Copy link
Owner Author

Tremendous effort but little gain. Closing.

@github-project-automation github-project-automation bot moved this from Consider to Done in Rifiuti2 progress Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows Windows specific issues wontfix
Projects
Rifiuti2 progress
Archived in project
Milestone
0.9 release
Development

No branches or pull requests
1 participant
@abelcheung