Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a RiemannSurface constructor function #131

Open
cswiercz opened this issue Jul 11, 2016 · 0 comments
Open

Create a RiemannSurface constructor function #131

cswiercz opened this issue Jul 11, 2016 · 0 comments

Comments

@cswiercz
Copy link
Member

It's really messy performing all of the required initialization in RiemannSurface.__init__, particularly when managing all of the dependencies on RiemannSurfacePathFactory. Besides, if the path factory object bugs out for some reason then we might be left with an uninitialized object which is really poor programming style.

Instead, create a function RiemannSurface which returns a RiemannSurfaceGeneric object. (This also sets up the possibility of a RiemannSurfaceHyperelliptic object which simplifies certain computations.) The RiemannSurfaceGeneric object will, in turn, be initialized with a PathFactory object which, I believe, only needs to depend on the underlying curve.

This is an opportunity for a better design as well as an opportunity to start working on a Voronoi-based path factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant