-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed net462 from test project #65
Conversation
What kind of errors? |
System.TypeLoadException : Could not load type 'System.Security.Cryptography.ECPoint' from assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. |
That's the error i told you about here: MeikTranel/MigrationSupport#1 (comment) The issue is that .NET Standard 2.0 has APIs that .NET v4.6.2 doesn't have, but the .NET team still marked 4.6.2 as .NET Standard 2.0 compatible. One of the 43 APIs missing is the one you have here (https://github.com/dotnet/standard/blob/master/docs/comparisons/netstandard2.0_vs_net461/System.Security.Cryptography.md); which is why your test fails on .NET462. Because you produce .NET Standard packages this means that there can be consumers of your package using .NET 4.6.2, that will eventually hit this bug. That's why i added 4.6.2 in the first place. |
I just checked. There's a nuget package that can help you avoid this scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to avoid this. I will test things locally to fix this problem differently.
Hmm. I see. Well. We either take on a dependency (maybe Source Include this as well?) or add a disclaimer that net.462 is not supported due to this issue (not very nice) |
Well the dependency would only exist for the net46X depedency group, not for the main netstandard2.0 dependencygroup. |
I believe the failing test is due to #32 |
I will be fixing #32 soon. Just been considering the best way to do it. |
This should be clean now. |
@MeikTranel Do you think we should avoid removing net462? @aseigler It does passes in the CI now. Good work. |
Sorry, christmas chores came first 😄 |
@MeikTranel Looks really good! Send a PR? :) And good idea to link to an issue at github (or a net462.md file) in the repo. |
Will do but tomorrow tho. Already back into Christmas Dinner Madness V2 😂 |
Running ```dotnet test`` generates a bunch of errors if net462 is targeted.