-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite loop in http parser #513
Labels
Bug
Bug report in proxy server
Comments
@bratao Thank you for reporting this. Will capture this into a test case and push the fix with next release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
@abhinavsingh Thanks for this unique and awesome project.
I use this library to do a transparent proxy balancer using async.
After a random period, it was freezing my application, and I found the cause to an infinite loop in this proxy.py code:
proxy.py/proxy/http/parser.py
Line 151 in 2931045
The request is kind of strange. The content-length is 0 but with a body payload. Looks like a malformed request. But ideally, it should not infinite loop the parser like this. I solved locally by limiting the number of times to loop, but looks like a bad fix.
The request and headers are the following:
Headers:
{b'server': (b'Server', b'WebProxy/1.0 Pre-Alpha'), b'date': (b'Date', b'Sat, 13 Mar 2021 02:19:56 GMT'), b'content-length': (b'Content-Length', b'0'), b'connection': (b'Connection', b'keep-alive')}
Raw request
Version information
The text was updated successfully, but these errors were encountered: