Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make in_channels and out_channels sets instead of arrays. #6

Open
abinashmeher999 opened this issue Jul 22, 2017 · 3 comments
Open

Comments

@abinashmeher999
Copy link
Owner

The member variables in_channels and out_channels in Process class don't need any ordered iteration. They can very well be turned into sets. The addition and deletion will be efficient then.

Expected Behavior

in_channels and out_channels are of type set.

Current Behavior

They are lists.

Possible Solution

Refactor the code

Your Environment

  • Version of the package used: master
  • Python version (Interpreter too if relevant): Python 3.5.3
  • Operating System and version: Ubuntu 14.04
@abinashmeher999
Copy link
Owner Author

@ayuhsya Want to give it a try?

@ayuhsya
Copy link

ayuhsya commented Aug 11, 2017

@abinashmeher999 I couldn't find any usages of in_channels and out_channels. How do I test it?

@abinashmeher999
Copy link
Owner Author

Currently I am testing through echo_algorithm.py. Ensure that it terminates and the process id and the message content on the last line to get printed are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants