Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: store TokenParams for subsequent authorisations #114

Closed
ricardopereira opened this issue Dec 31, 2015 · 5 comments
Closed

Auth: store TokenParams for subsequent authorisations #114

ricardopereira opened this issue Dec 31, 2015 · 5 comments
Assignees
@ricardopereira
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ricardopereira
Copy link
Contributor

Auth#authorise (RSA10g) Stores the AuthOptions and TokenParams arguments as defaults for subsequent authorisations

ARTAuth does not store the AuthOptions/TokenParams for subsequent authorisations.
@ricardopereira ricardopereira added bug Something isn't working. It's clear that this does need to be fixed. rest labels Dec 31, 2015
@ricardopereira ricardopereira mentioned this issue Jan 5, 2016
Merged
@ricardopereira ricardopereira self-assigned this Jan 7, 2016
@ricardopereira
Copy link
Contributor Author

@mattheworiordan About storing the TokenParams, should I store the timestamp field? As far as I know the timestamp should always have the time of the current request, right?

@mattheworiordan
Copy link
Member

@ricardopereira that is a very good point, the timestamp field should not be stored. I believe every other client library blindly stores the complete hash. I will need to add an issue to all client libraries to exclude the timestamp and the nonce

@mattheworiordan
Copy link
Member

Sorry, nonce is a TokenRequest field, ignore me. However, force attribute of AuthOptions should also not be stored as this would then mean every auth check would force a new authentication

@ricardopereira
Copy link
Contributor Author

@mattheworiordan Yes, I was questioning me as well about AuthOptions.force. So, I will implement it without storing timestamp and force. 👍

@mattheworiordan
Copy link
Member

See ably/docs@f768f0d

maratal pushed a commit that referenced this issue Jul 19, 2023
@QuintinWillison
Merge pull request #114 from ably/format-description-lists
2adec3f 
Format description lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardopereira ricardopereira

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @ricardopereira