Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document thread-safety requirements in current version #601

Closed
3 tasks done
mattheworiordan opened this issue May 12, 2017 · 8 comments
Closed
3 tasks done

Document thread-safety requirements in current version #601

mattheworiordan opened this issue May 12, 2017 · 8 comments
Labels
enhancement New feature or improved functionality.

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented May 12, 2017

We need to document that the iOS lib is not thread-safe and thus we need to:

  • Add documentation in realtime usage section stating that the iOS lib is not thread-safe, with a high level summary of the types of problems they can expect, a recommendation and link to how Apple recommends they deal with concurrency and provide a very simple example of how to address this using for example GCD sync dispatch.
  • Add the above notes to Github
  • Add info about the objects we pass in listeners and notes on their safety to use in that we don't keep references to them.
@mattheworiordan mattheworiordan added the enhancement New feature or improved functionality. label May 12, 2017
@tcard
Copy link
Contributor

tcard commented May 15, 2017

See 0e48e63.

@mattheworiordan
Copy link
Member Author

@tcard 0e48e63 is not a commit?

@tcard
Copy link
Contributor

tcard commented May 17, 2017

@mattheworiordan Sorry, it's a commit on docs: ably/docs@0e48e63

@tcard
Copy link
Contributor

tcard commented May 17, 2017

BTW, as part of #603 I put state transitions in GCD serial queues, which should reduce thread-safety issues and possibly even make the library internally thread-safe.

@paddybyers
Copy link
Member

and possibly even make the library internally thread-safe

You don't sound very sure?

@tcard
Copy link
Contributor

tcard commented May 17, 2017

@paddybyers It definitely improves the situation, I'm not sure if it makes it completely thread-safe internally.

@mattheworiordan
Copy link
Member Author

You don't sound very sure?

@paddybyers remember we still have our spike to complete

@tcard
Copy link
Contributor

tcard commented Nov 3, 2017

Done.

@tcard tcard closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

3 participants