Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust stats API to spec. #173

Merged
merged 1 commit into from
Feb 2, 2016
Merged

Adjust stats API to spec. #173

merged 1 commit into from
Feb 2, 2016

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Jan 29, 2016

No description provided.

@tcard tcard force-pushed the adjust-stats branch 2 times, most recently from 5596652 to 3850f8f Compare January 29, 2016 21:47
@ricardopereira
Copy link
Contributor

I run the tests and got:

ObjC - ARTRestCryptoTest

testSendBinary, ((!error) is true) failed
/Users/ricardopereira/Repositories/Whitesmith/ably-ios/ably-iosTests/ARTRestCryptoTest.m:49

testSendBinary, (([page count]) equal to (2)) failed: ("1") is not equal to ("2")
/Users/ricardopereira/Repositories/Whitesmith/ably-ios/ably-iosTests/ARTRestCryptoTest.m:56

testSendBinary, failed: caught "NSRangeException", "*** -[__NSArrayM objectAtIndex:]: index 1 beyond bounds [0 .. 0]"
/Users/ricardopereira/Repositories/Whitesmith/ably-ios/ably-iosTests/ARTRestCryptoTest.m:58

Swift tests are passing. 👍

ricardopereira
ricardopereira reviewed Jan 30, 2016
View reviewed changes
ably-ios/ARTStats.h
};

ART_ASSUME_NONNULL_BEGIN
__GENERIC(NSArray, NSString *) *ARTStatsIntervalFormatString;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this global variable. Why do you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this is a leftover.

@ricardopereira
Copy link
Contributor

LGTM, just a small comment.

@mattheworiordan
Copy link
Member

LGTM

tcard added a commit that referenced this pull request Feb 2, 2016
@tcard
Merge pull request #173 from ably/adjust-stats
12d5c77 
Adjust stats API to spec.
@tcard tcard merged commit 12d5c77 into master Feb 2, 2016
@tcard tcard mentioned this pull request Feb 2, 2016
Closed
@tcard tcard deleted the adjust-stats branch February 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcard @ricardopereira @mattheworiordan