RTL3b #184
Merged
RTL3b #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardopereira
force-pushed
the
RTL3b
branch
2 times, most recently
from
3d0a315 to
8c61cb9
Compare
|
LGTM |
| @@ -47,9 +47,7 @@ typedef NS_ENUM(NSUInteger, ARTRealtimeChannelState) { | |||
| ARTRealtimeChannelInitialised, | |||
| ARTRealtimeChannelAttaching, | |||
| ARTRealtimeChannelAttached, | |||
| ARTRealtimeChannelDetaching, | |||
There was a problem hiding this comment.
State Detaching exists, see http://docs.ably.io/client-lib-development-guide/features/#RTL2a, why was this removed?
There was a problem hiding this comment.
I changed it according to http://docs.ably.io/realtime/channels-messages/ Channel states topic. I will undo.
There was a problem hiding this comment.
As mentioned before, the only definitive spec is at http://docs.ably.io/client-lib-development-guide/features/. I am working on bringing all the other docs up to date, but they're not there yet.
ricardopereira
force-pushed
the
RTL3b
branch
2 times, most recently
from
4b8a0dc to
ff73f70
Compare
|
Rebased with changes. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.