Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught HTTP exception #289

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Conversation

ricardopereira
Copy link
Contributor

  • should always enqueue the callback block

 - should always enqueue the callback block
@mattheworiordan
Copy link
Member

Not sure I understand why this change is needed, @tcard over to you

@ricardopereira
Copy link
Contributor Author

@mattheworiordan I fixed it because it was raising an exception when a request was returning 500 (see here). It was calling the callback (here) without enqueuing the block on the current loop.

BTW, the sandbox seems to be unstable.

@mattheworiordan
Copy link
Member

BTW, the sandbox seems to be unstable.

Yes, we are oddly getting an unstable sandbox quite frequently. I will ask Paddy to fix it now, sorry

@ricardopereira
Copy link
Contributor Author

And with this bug (all night on this one 😅) I found out that the xcpretty ignores abnormal failures, consequently the log hangs and Travis kills the process. I reproduce it successfully: https://github.com/ricardopereira/CrashTestSuiteExample.

@mattheworiordan
Copy link
Member

And with this bug (all night on this one 😅) I found out that the xcpretty ignores abnormal failures,

Well done finding that one!

@tcard
Copy link
Contributor

tcard commented Mar 10, 2016

LGTM

ricardopereira added a commit that referenced this pull request Mar 10, 2016
@ricardopereira ricardopereira merged commit 667a1e5 into master Mar 10, 2016
@ricardopereira ricardopereira deleted the fix-uncaught-http-exception branch March 10, 2016 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants