-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSP3a2 #365
RSP3a2 #365
Conversation
realtimeChannel.presence.enterClient("john", data: "mobile") | ||
realtimeChannel.presence.enterClient("casey", data: "web") | ||
realtimeChannel.presence.enterClient("casey", data: "mobile") | ||
realtimeChannel.presence.enterClient("john", data: "web") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you entering the same clientId 3 times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was checking if the member was updating the data and I forgot to remove it. Fixed 31f0591.
One comment but otherwise good, surprised this didn't pass given it's just REST |
@ricardopereira It's supposed to be REST, but the tests is actually using RealtimePresence.get instead of RestPresence.get. |
Sorry, scratch that one. Not true, it's correct. |
@@ -11,6 +11,12 @@ | |||
|
|||
#import "ARTPresence.h" | |||
|
|||
@interface ARTPresenceQuery () | |||
|
|||
- (NSMutableArray /* <NSURLQueryItem *> */ *)asQueryItems; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (__GENERIC(NSMutableArray, NSURLQueryItem *) *)asQueryItems;
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed at debbfa2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM |
expect(member.action).to(equal(ARTPresenceAction.Update)) | ||
expect(member.clientId).to(equal("john")) | ||
expect(member.data as? NSObject).to(equal("away")) | ||
partlyDone() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was wrong with this exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't know. I spend so much time with this: the flow is correct, the log doesn't show anything weird, I tried debug the problem but it never happened when I was debugging.
No description provided.