Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSP3a2 #365

Merged
merged 5 commits into from
Apr 8, 2016
Merged

RSP3a2 #365

merged 5 commits into from
Apr 8, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

realtimeChannel.presence.enterClient("john", data: "mobile")
realtimeChannel.presence.enterClient("casey", data: "web")
realtimeChannel.presence.enterClient("casey", data: "mobile")
realtimeChannel.presence.enterClient("john", data: "web")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you entering the same clientId 3 times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking if the member was updating the data and I forgot to remove it. Fixed 31f0591.

@mattheworiordan
Copy link
Member

One comment but otherwise good, surprised this didn't pass given it's just REST

@tcard
Copy link
Contributor

tcard commented Apr 5, 2016

@ricardopereira It's supposed to be REST, but the tests is actually using RealtimePresence.get instead of RestPresence.get.

@tcard
Copy link
Contributor

tcard commented Apr 5, 2016

Sorry, scratch that one. Not true, it's correct.

@@ -11,6 +11,12 @@

#import "ARTPresence.h"

@interface ARTPresenceQuery ()

- (NSMutableArray /* <NSURLQueryItem *> */ *)asQueryItems;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- (__GENERIC(NSMutableArray, NSURLQueryItem *) *)asQueryItems;?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at debbfa2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ricardopereira
Copy link
Contributor Author

LGTM

expect(member.action).to(equal(ARTPresenceAction.Update))
expect(member.clientId).to(equal("john"))
expect(member.data as? NSObject).to(equal("away"))
partlyDone()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was wrong with this exactly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't know. I spend so much time with this: the flow is correct, the log doesn't show anything weird, I tried debug the problem but it never happened when I was debugging.

@ricardopereira ricardopereira merged commit 232f4be into master Apr 8, 2016
@ricardopereira ricardopereira deleted the rsp3a2 branch April 8, 2016 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants