Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN15h #442

Merged
merged 3 commits into from
May 2, 2016
Merged

RTN15h #442

merged 3 commits into from
May 2, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@mattheworiordan
Copy link
Member

LGTM

@tcard
Copy link
Contributor

tcard commented Apr 29, 2016

I don't think this test is right. It should be like RTN14b, whose spec is exactly the same except it's an ERROR ProtocolMessage instead of DISCONNECTED. I'll adapt it.

@tcard
Copy link
Contributor

tcard commented Apr 29, 2016

PTAL

@ricardopereira
Copy link
Contributor Author

ricardopereira commented May 1, 2016 •
edited
Loading

👍 Thanks

@tcard tcard merged commit 00ded91 into master May 2, 2016
@tcard tcard deleted the rtn15h branch May 2, 2016 08:57
tcard pushed a commit that referenced this pull request May 16, 2016
@ricardopereira @tcard
RTN15h (#442)
e9e8941
maratal pushed a commit that referenced this pull request Jul 19, 2023
@paddybyers
Merge pull request #442 from withakay/RTN24-typo-master
002c007 
RTN24 referenced RTL4h, should be RTN4h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @mattheworiordan @tcard