Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN3 #45

Merged
merged 7 commits into from
Nov 13, 2015
Merged

RTN3 #45

merged 7 commits into from
Nov 13, 2015

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@mattheworiordan
Copy link
Member

@ricardopereira why don't you base your PR on an existing PR? This PR includes commits from other PRs unnecessarily, it should only include the commits relating to this PR. When you create a PR, you can chose to base it off another PR. Please do this in future to remove unnecessary duplication so that people reviewing the PRs are only reviewing the relevant commits

@ricardopereira
Copy link
Contributor Author

@ricardopereira why don't you base your PR on an existing PR? This PR includes commits from other PRs unnecessarily, it should only include the commits relating to this PR. When you create a PR, you can chose to base it off another PR. Please do this in future to remove unnecessary duplication so that people reviewing the PRs are only reviewing the relevant commits

Didn't no. I will do that for now on.

@mattheworiordan
Copy link
Member

This looks good, is it ready for merge, or do you have any other points to address?

@ricardopereira
Copy link
Contributor Author

@mattheworiordan It's ready. Thank you.

mattheworiordan added a commit that referenced this pull request Nov 13, 2015
@mattheworiordan
Merge pull request #45 from ricardopereira/rtn3
15cb589 
RTN3
@mattheworiordan mattheworiordan merged commit 15cb589 into ably:master Nov 13, 2015
@ricardopereira ricardopereira deleted the rtn3 branch November 13, 2015 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @mattheworiordan