Fix RSC11: ignore environment when host is customized #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,8 +173,20 @@ class RestClient: QuickSpec { | |||
|
|
|||
| expect(testHTTPExecutor.requests.first?.URL?.host).toEventually(equal("fake.ably.io"), timeout: testTimeout) | |||
| } | |||
|
|
|||
| it("should ignore an environment when host is not in production") { | |||
There was a problem hiding this comment.
What does a host being "in production" mean?
There was a problem hiding this comment.
@tcard not sure if @ricardopereira is around unfortunately.
There was a problem hiding this comment.
@tcard I assumed that "in production" is when restHost ≠ default value.
There was a problem hiding this comment.
@tcard perhaps you should just take the PR and reword as you see fit as @ricardopereira is away on holiday for a little while still
There was a problem hiding this comment.
OK, I think that "when environment is not 'production'" is more explicit.
There was a problem hiding this comment.
Sorry, that's not what's happening here at all. Well, da76de0 it is.
|
LGTM, although a comment abut TOK3k2 would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/ably/ably-ios/pull/473/files/2d05f1bdffb5587cdd006a7e0ebefd158c67c8fb#r77165419