Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC15a #509

Merged
merged 4 commits into from
Oct 11, 2016
Merged

RSC15a #509

merged 4 commits into from
Oct 11, 2016

Conversation

ricardopereira
Copy link
Contributor

Work from #466

@tcard
Copy link
Contributor

tcard commented Oct 11, 2016

Honestly, I'd like the test to take the approach I mentioned here: #466 (comment)

@ricardopereira
Copy link
Contributor Author

@tcard Changed. PTAL at f88d683.

tcard
tcard approved these changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@tcard tcard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardopereira ricardopereira merged commit d3a5049 into master Oct 11, 2016
@ricardopereira ricardopereira deleted the RSC15a branch October 11, 2016 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcard tcard tcard approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @tcard @CezaryKopacz