Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC11: Environment option #160

Closed
mattheworiordan opened this issue Sep 14, 2016 · 5 comments
Closed

RSC11: Environment option #160

mattheworiordan opened this issue Sep 14, 2016 · 5 comments
Assignees

Comments

@mattheworiordan
Copy link
Member

Please can we add an environment option to the Java lib which simply prepends the environment to the full domain for rest & realtime i.e. clientOptions.environment = 'foo' would result in it connecting to foo-rest.ably.io and foo-realtime.ably.io respectively for REST and Realtime endpoints.

See iOS and Javascript libraries for comparable implementations.

@mattheworiordan
Copy link
Member Author

@mattheworiordan mattheworiordan changed the title Environment option RSC11: Environment option Sep 14, 2016
@VOstopolets
Copy link
Contributor

VOstopolets commented Sep 15, 2016

@mattheworiordan From http://docs.ably.io/client-lib-development-guide/features/#RSC11, environment option prepends the environment to the full domain only for REST endpoint. For Realtime, this is covered by http://docs.ably.io/client-lib-development-guide/features/#RTC1e. So, should I implement RTC1e too?

@mattheworiordan
Copy link
Member Author

@VOstopolets I believe you have done this? Should I close?

@VOstopolets
Copy link
Contributor

@mattheworiordan I have created PR for this task #162 (covered by TO3k1, RSC11, RTC1e), and it haven't approved.

@mattheworiordan
Copy link
Member Author

Given there is a PR that will be merged soon I am going to close this, thanks @VOstopolets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants