Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realtime Channel: exceptions thrown when attempting attach do not result in the client listener being called #448

Closed
paddybyers opened this issue Jan 2, 2019 · 0 comments
Closed

Realtime Channel: exceptions thrown when attempting attach do not result in the client listener being called #448

paddybyers opened this issue Jan 2, 2019 · 0 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@paddybyers
Copy link
Member

(i) if the attachImpl throws an exception (https://github.com/ably/ably-java/blob/release-1.0.9/lib/src/main/java/io/ably/lib/realtime/Channel.java#L311) it will set the attachTimer to null;

(ii) if the attachTimer is null, it will return without calling the listener https://github.com/ably/ably-java/blob/release-1.0.9/lib/src/main/java/io/ably/lib/realtime/Channel.java#L314
@paddybyers paddybyers added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 2, 2019
@paddybyers paddybyers mentioned this issue Jan 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paddybyers