Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST client not attempting fallback hosts upon httpOpenTimeout expiry #997

Closed
owenpearson opened this issue Mar 26, 2024 · 0 comments
Closed
Assignees
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@owenpearson
Copy link
Member

owenpearson commented Mar 26, 2024

It has been observed that when using the generic request method, if ClientOptions.httpOpenTimeout expires, clients do not retry the request with fallback hosts, but instead fail immediately with java.net.SocketTimeoutException: Connect timed out.

This should be easy enough to reproduce by setting httpOpenTimeout sufficiently low and observing in logs whether the client attempts to use fallback hosts.

We should also check whether fallback hosts are attempted for other timeouts, in particular, httpRequestTimeout (nb: until #310 is resolved, the default httpRequestTimeout is the same as httpMaxRetryDuration so probably won't try fallbacks if expired anyway).

┆Issue is synchronized with this Jira Task by Unito

@owenpearson owenpearson added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 26, 2024
@ably ably deleted a comment from sync-by-unito bot Mar 27, 2024
@sync-by-unito sync-by-unito bot closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

2 participants