Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis version support #21

Closed
mattheworiordan opened this issue Dec 16, 2015 · 1 comment
Closed

Travis version support #21

mattheworiordan opened this issue Dec 16, 2015 · 1 comment
Assignees
@bladeSk
Labels
bug Something isn't working. It's clear that this does need to be fixed. enhancement New feature or improved functionality.

Comments

@mattheworiordan
Copy link
Member

@bladeSk as you have added PHP 7 support, I think it's important that our test suite runs against multiple versions. If you look at https://github.com/ably/ably-php/blob/master/.travis.yml#L3, you will see we only support 5.4 now. Should we not run the test suite against all support PHP versions to make sure we don't introduce regressions in future?

See https://docs.travis-ci.com/user/languages/php/
@mattheworiordan mattheworiordan added bug Something isn't working. It's clear that this does need to be fixed. enhancement New feature or improved functionality. labels Dec 16, 2015
@bladeSk
Copy link
Contributor

bladeSk commented Dec 19, 2015

Done

@bladeSk bladeSk closed this as completed Dec 19, 2015
@charles85 charles85 mentioned this issue Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bladeSk bladeSk

Labels
bug Something isn't working. It's clear that this does need to be fixed. enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @bladeSk